storefront icon indicating copy to clipboard operation
storefront copied to clipboard

Published 20 hours ago • verified publisher icon woocommerce

Add support for sub menu description

Open nielslange opened this issue 2 years ago • 2 comments

Fixes #1595

This PR is an extension of #1771 and adds support for the submenu description. @gigitux mentioned this specific problem in https://github.com/woocommerce/storefront/pull/1771#issuecomment-1087301359.

In this PR, I simply enhanced the SCSS styles to style the descriptions of both the menu and the submenu items similar.

Screenshots

Before:

#1595-before

 After:

#1595-after

How to test the changes in this Pull Request:

  1. Go to /wp-admin/nav-menus.php.
  2. Click on screen options in the upper-right corner and activate the option Description within Show advanced menu properties.
  3. Create a custom menu and assign it to the menu location Secondary Menu.
  4. Add 2-3 menu items with a description.

Changelog

Add support for submenu description.

nielslange avatar Apr 04 '22 10:04 nielslange

Related to this PR, there are still some works to do. For more context, check #1771. @tjcafferkey Can you de-approved the PR? In this way, we are sure that anyone will not merge this PR.

gigitux avatar Apr 04 '22 14:04 gigitux

@Procorners For this PR there are still some works to do. For more context, check #1771

gigitux avatar Apr 06 '22 16:04 gigitux