storefront icon indicating copy to clipboard operation
storefront copied to clipboard

"Thumbnail cropping" tool in Customizer is poor UX, in fact affects Catalog Images only

Open fylgjur opened this issue 3 years ago • 2 comments

Is your feature request related to a problem? Please describe.

It is very hard to intuitively interpret the Customizer here:

Screen-Shot-2020-07-13-at-09 56 06

A user in 3621066-zen points out that 'Thumbnail' should refer to the gallery thumbnails below the main product image on the product page:

Screenshot

We clearly refer to Product Thumbnails in our docs as being these gallery thumbnails. In fact, this Customiser setting only affects the Catalog Images if we go by the vocabulary in this documentation. It does not affect the Single Product Image or the Product Thumbnails despite the tool being named Thumbnail Cropping.

I'm writing bearing in mind this closed issue: https://github.com/woocommerce/storefront/issues/774 I appreciate that Storefront does not support custom image sizes out of the box, hence this is an enhancement request for a better user experience.

Describe the solution you'd like

  • We rename the section of the Customiser to "Catalog Image Cropping"? Is this a thing that can be done on Storefront's side or is it a wider WordPress issue?

Describe alternatives you've considered

  • (Easiest, but no product improvement) We edit the documentation to make clear what image types are affected here and that changing the ratio or cropping of the product thumbnails or the single product image is only possible with custom code.
  • We could provide this custom code in a developers doc for Storefront.

fylgjur avatar Jan 04 '21 18:01 fylgjur

The customer replied back and mentioned that they added the following code to theme's functions.php and now the images are sized in 4:3 aspect ratio:

// Change Woo thum size

add_filter( 'woocommerce_get_image_size_gallery_thumbnail', function( $size ) {

return array(

'width' => 160,

'height' => 120,

'crop' => 0,

);
}
);

anant1811 avatar Jan 05 '21 04:01 anant1811

I was directed to this info giving more on the vocabulary in the actual code of the different types of images here: https://docs.woocommerce.com/document/image-sizes-theme-developers/

This use of thumbnail in the code suggests to me that we should modify the vocabulary in the Types of Images documentation to match what the code says.

I submitted this for consideration in p1609942993473900-slack-CSP74N77C

fylgjur avatar Jan 06 '21 14:01 fylgjur