Custom text color in blocks is broken in editor - customizer styles not consistently applied in editor

[Aljullu]

Filling it so we can track this for following releases, even though the issue only affects the last version of Gutenberg master so it might make sense to wait until an official release is done.

To Reproduce

1. In the editor, change the text color of a paragraph block.
2. Notice changes are not applied. That's because it doesn't have a style attribute anymore and one of our CSS rules (.editor-styles-wrapper .block-editor-block-list__block) overrides the base styles.

Screenshots

Expected behavior

Changes in the text color should have an effect in the editor.

[Aljullu]

An update on this: Gutenberg 8.0.0 was released and this issue is reproducible.

I also tested, and links are not correctly styled either.

[GlennMartin1]

Review this comment in the Gutenberg issue: https://github.com/WordPress/gutenberg/issues/21931#issuecomment-624814695

[haszari]

Thanks for tracking that down @GlennMartin1 !

I've pulled the relevant part of the comment here for clarity:

The issue here is that Twenty Nineteen was not loading its color palette stylesheet on the editor.

Possibly we have the same issue in Storefront.

[GlennMartin1]

Could this be milestoned for 2.5.7?

[haszari]

Added to milestone for now – still deciding what we're focusing on this release but would be good to tidy this up.

[GlennMartin1]

This issue's title is incorrect and should be revised.

The problem is not Gutenberg. Instead, the problem is that Storefront is (presumably) not loading the color palette stylesheet on the editor.

[haszari]

The problem is not Gutenberg. Instead, the problem is that Storefront is (presumably) not loading the color palette stylesheet on the editor.

Thanks Glenn - I've updated the title. Personally I prefer issues that are focused on the user-facing problem, not a particular code solution. Hopefully I've captured the problem in the new title!

[haszari]

Let's hold off on this for now – I see the discussion is still ongoing in Gutenberg, and there's a now a Gutenberg PR open to address the issue.

It looks like this is still being worked out - this affects many themes. When Gutenberg is released and there's guidance on the best fix, we can implement in Storefront.

[haszari]

Could be fixed in Gutenberg: https://github.com/WordPress/gutenberg/issues/21931#event-3514907525

[ericamQA]

Another instance in 3883197-zen

[KirkwallDay]

An instance of this here: 23525996-hc