storefront icon indicating copy to clipboard operation
storefront copied to clipboard

Improve customisation of mobile footer bar colors (independent from header colors or footer colors)

Open jarretc opened this issue 5 years ago • 7 comments

Apologies if this has already had an issue created as I wasn't able to find anything through searching.

When adjusting the 'Link color' in the customizer under the Header section, it also controls the color of the handheld footer bar icons when viewing on a mobile device. As the handheld footer bar isn't a part of the header area, adjustments to that item should be in a separate section or not implemented at all and remain as black icons on a white background.

jarretc avatar Nov 14 '19 09:11 jarretc

Thank you for raising this issue @jarretc. I can reproduce it:

When changing the Link color in the Customizer / Header, the color of the handheld menu items on the mobile is changing as well:

header

link_color

Mobile - before the change:

black

Mobile - after the change:

red

Technically, the items on the handheld menu are a part of the main menu on the desktop which is the reason why they are changing the color in tandem.

With that said, I can see how it can be beneficial to add a separate option to control the color of the handheld menu items. Perhaps Customizer / Footer will be a good place for that as you mentioned.

I will mark this issue as enhancement for now.

In the meantime, you can change the color of the items in the handheld menu using CSS snippet below:

/* Changes the color of the handheld menu items on mobile devices */
.storefront-handheld-footer-bar ul li > a:before {
	color: black;
}

/* Changes the color of the cart count of the handheld menu cart item on mobile devices */
.storefront-handheld-footer-bar ul li.cart .count {
    background-color: black;
}

You can place any color instead of black in that snippet. The result looks as follows:

rb

juliaamosova avatar Nov 15 '19 12:11 juliaamosova

It looks like this is generating a lot of problems. The other GH issue linked has several reports, along with these here: https://wordpress.org/support/topic/storefront-handheld-footer-bar-not-showing/

Changing this to a bug.

jessepearson avatar Mar 25 '20 10:03 jessepearson

Looks like this issue may have been introduced in 2.5.5 with #1261. We can look at reverting that fix or improving this in 2.5.6.

haszari avatar Apr 15 '20 04:04 haszari

Looks like this issue may have been introduced in 2.5.5 with #1261. We can look at reverting that fix or improving this in 2.5.6.

I'll look this issue and create a fix for it.

nielslange avatar Apr 15 '20 08:04 nielslange

@nielslange are you working on this? I was looking at #1302 and I think it might make sense fixing both issues in parallel. But if you already started working on it I will leave it for you. :slightly_smiling_face:

Aljullu avatar Apr 20 '20 14:04 Aljullu

I've grabbed this and #1302, aiming to get a PR up today.

haszari avatar Apr 20 '20 22:04 haszari

Pulling this from the milestone and resetting to enhancement (updating title also).

There's a related issue in #1302 and also reported on the forum which we are fixing in 2.5.6 (PR incoming - #1321 (edit)).

However regarding a new feature to allow customisation of the footer bar colors independent of the header colors – we'll track that as an enhancement request.

haszari avatar Apr 20 '20 23:04 haszari