pinterest-for-woocommerce icon indicating copy to clipboard operation
pinterest-for-woocommerce copied to clipboard

Published 20 hours ago • verified publisher icon woocommerce

Fix feed location check and force HTTPS over HTTP.

Open message-dimke opened this issue 8 months ago • 3 comments

Changes proposed in this Pull Request:

  • Replacing get_site_url with wp_get_upload_dir for the feed location check.
  • Forcing HTTPS over HTTP for the feed location URI.

Additional details:

Changelog entry

Fix - Feed location URL matching.

message-dimke avatar Mar 24 '25 11:03 message-dimke

If a site doesn't use HTTPS, what will happen? Would it make sense to check is_ssl() to determine whether to force http or https? If the site doesn't have a valid certificate, would unconditionally forcing https still work?

layoutd avatar Mar 25 '25 13:03 layoutd

Also is this a draft still?

layoutd avatar Mar 25 '25 13:03 layoutd

Hey, @layoutd !

I believe that for any e-commerce store SSL is a must. Most payment gateways require it, etc. To my understanding is_ssl won't give you any information if the website has SSL configured, it will tell you if the current page is served by HTTPS or not. I would always force HTTP to HTTPS.

message-dimke avatar Mar 25 '25 20:03 message-dimke