google-listings-and-ads icon indicating copy to clipboard operation
google-listings-and-ads copied to clipboard

Published 20 hours ago • verified publisher icon woocommerce

Onboarding: Remove Google MC and Google Ads Cards

Open joemcgill opened this issue 1 year ago • 6 comments

As part of #2509, we will be consolidating the UI for connecting to Google Merchant Center and Google Ads accounts into a unified UI with the GoogleAccountCard.

To begin this effort, we'll remove the existing GoogleAdsAccountCard and GoogleMCAccountCard components from the SetupAccounts flow of the onboarding flow.

image

Acceptance Criteria

  • [ ] The Google Ads card is not shown on step one of onboarding
  • [ ] The Google Merchant Center card is not shown on step one of onboarding
  • [ ] The disclaimer text associated with the MC card GoogleMCDisclaimer is moved to the footer next to the FAQs (see screenshot).
  • [ ] The continue button remains disabled even after the WP.com and Google cards are connected.
  • [x] UI changes showed in the Google card are out of scope of this issue.

Implementation Brief

[!NOTE] This work should be branched from feature/2458-streamline-onboarding and a PR should be created against the feature/2458-consolidate-google-account-cards branch.

The SetupAccounts component that needs to be edited is here.

Test Coverage

  • E2E tests in tests/e2e/specs/setup-mc/step-1-accounts.test.js are expected to fail until #2509 is complete.

Definition Questions

joemcgill avatar Aug 23 '24 18:08 joemcgill

@eason9487 would you mind validating this subtask? The goal of this one is just to set up the UI ahead of the consolidation effort being worked on via all of the #2509 tasks.

joemcgill avatar Aug 23 '24 19:08 joemcgill

I don't think there is much risk in getting started with this, so I'm marking this as ready for work to unblock the start of this effort.

joemcgill avatar Aug 30 '24 15:08 joemcgill

Not sure how the original disconnect function for each account card will be consolidated into the new UI during onboarding?

eason9487 avatar Sep 03 '24 02:09 eason9487

@ankitguptaindia this is ready for QA. Note that this is a sub-task of #2509, so the onboarding flow will not be able to be completed until the whole feature is complete.

@eason9487

Not sure how the original disconnect function for each account card will be consolidated into the new UI during onboarding?

All of the functionality handled by the separate cards will be handled within the consolidated UI being started in #2566 as part of #2509.

joemcgill avatar Sep 05 '24 17:09 joemcgill

Engineering complete and approved, moving to UAT for @fblascogarma final approval

eclarke1 avatar Sep 09 '24 11:09 eclarke1

Just tagging @joemcgill and @dsawardekar to advise this needs to be merged please

eclarke1 avatar Sep 09 '24 16:09 eclarke1

Closing this as completed since it was part of the 2.9 release.

mikkamp avatar Dec 02 '24 15:12 mikkamp