google-listings-and-ads icon indicating copy to clipboard operation
google-listings-and-ads copied to clipboard

Misalignment in settings screen

Open mikkamp opened this issue 1 year ago • 2 comments

Describe the bug:

When we view the settings screens the left and right column text isn't aligned.

image

I'd expect the text in the left section to either remove the top padding so it's aligned with the top of the right section, or alternatively have it aligned with the height of the text on the right section.

Steps to reproduce:

  1. Go to a site that has completed onboarding
  2. Browse to the Marketing > Google Listings & Ads > Settings
  3. View the misalignment

Additional details:

This especially becomes obvious as we add additional sections to the settings page, some which might not have text on the right side. image

mikkamp avatar Feb 23 '24 08:02 mikkamp

Thanks for reporting the issue @mikkamp . Notice this is not happening just in the Setting but in all the .wcdl-section__header classes.

puntope avatar Feb 23 '24 15:02 puntope

Notice this is not happening just in the Setting but in all the .wcdl-section__header classes.

Yes it's the same in onboarding and attributes page as well. Wondering though what's expected as when I look at the original figma files it also has some margin/padding there. However in some places that seems to align better with the first line of text on the right side. Do you know more about what's part is expected to line up?

mikkamp avatar Feb 23 '24 16:02 mikkamp