facebook-for-woocommerce icon indicating copy to clipboard operation
facebook-for-woocommerce copied to clipboard

Facebook Order sync action was not scheduled.

Open message-dimke opened this issue 3 years ago • 1 comments

Changes proposed in this Pull Request:

Some time ago commerce manage id option stopped to be set and turned the condition to evaluate to false when checking for Facebook order sync scheduled action. So fixing the sync scheduled action check condition. Besides commerce manage id appeared to be an unknown parameter, not a single doc has the reference to such a parameter name, the closest thing to commerce manage id is commerce account id, but still commerce manage id was not used anywhere else, so removing is an checking for page token to validate the connection should be sufficient. Orders fetching does not require commerce manage id, only page token.

Closes #2110.

Detailed test instructions:

  1. Before checking out the branch, go to WooCommerce > Scheduled Actions;

  2. Search for wc_facebook_commerce_fetch_orders and see no results found; WooCommerce_status_‹Regular-WordPress—_WordPress

  3. Checkout the branch with the fix and repeat those two steps above;

  4. You should see action scheduled; WooCommerce_status_‹WordPress-Facebook—_WordPress

Changelog entry

Fix - Facebook orders sync action is not scheduled.

message-dimke avatar May 24 '22 12:05 message-dimke

Nice work.

Lets hold off on shipping this one until we've aligned internally on order functionality as a whole

findingsimple avatar May 24 '22 22:05 findingsimple

Closed, we are not using order sync.

budzanowski avatar Nov 28 '22 12:11 budzanowski