action-scheduler icon indicating copy to clipboard operation
action-scheduler copied to clipboard

Remove grunt-phpcs?

Open coreymckrill opened this issue 1 year ago • 1 comments

It looks like we're using this grunt-phpcs package as a shortcut for running phpcs. However, the package hasn't been updated in 8 years, and it is supposed to be run with a very old version of Node. It seems like we could remove this package and just run phpcs via a composer script or something.

Here's the error I get when I run npm i:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '0.10.x' },
npm WARN EBADENGINE   current: { node: 'v16.19.1', npm: '8.19.4' }
npm WARN EBADENGINE }

coreymckrill avatar Apr 19 '23 19:04 coreymckrill

Seems we can get rid of most node js thingies here, we only need the package json fine to make it work with wc release tool. Marking as a enhancement request. Let us know if you want to sent a PR.

vedanshujain avatar May 02 '23 12:05 vedanshujain