FlexSlider icon indicating copy to clipboard operation
FlexSlider copied to clipboard

Less: Small fixes & improvements (box-shadow & font)

Open Ninos opened this issue 10 years ago • 10 comments

Fix: box-shadow

You should use ~"" instead of just "", otherwise you get following result after comiling: box-shadow: "" 0 1px 2px rgba( 0, 0, 0, 0.2 );

Improvement: Added possibility to disable the font-face

So it's possible to use custom font icons without loading the flexslider font icons (for better performance / less files to load on client side)

Here's an example with FontAwesome:

@font:                           false;
@font-name:                      "FontAwesome";
@flex-direction-nav-icon-prev:   "\f053";
@flex-direction-nav-icon-next:   "\f054";
@flex-pauseplay-icon-play:       "\f04b";
@flex-pauseplay-icon-pause:      "\f04c";

Ninos avatar Mar 04 '15 00:03 Ninos

Hey there, what's about this PR? These are only small fixes and simple improvements. Without this fix you cannot compile from .less e.g. with less.php... :-)

Ninos avatar Jun 27 '15 02:06 Ninos

Ref: #1277

Ninos avatar Jun 27 '15 02:06 Ninos

@jeffikus what's about following PR? :))

Ninos avatar Oct 05 '15 12:10 Ninos

@Ninos thanks but just no time to add to 2.6.0 release, have assigned to 2.7.0 though!

jeffikus avatar Nov 16 '15 15:11 jeffikus

Ok thank you!

Ninos avatar Nov 16 '15 15:11 Ninos

Hey there, this PR is still not merged, any news about that? These are small but significant improvements for theme developers which not want to load an additional font.

Ninos avatar Jul 12 '17 02:07 Ninos

@Ninos when i get time to tackle this I will, but at the moment there are more pressing issues that i need to deal with.

jeffikus avatar Jul 13 '17 11:07 jeffikus

Hey @jeffikus I'm sure you have no much time, but after version changes I always need to implement my small PRs into project libraries. These PRs are very small, if you have no time, you can add me as project dev, after that I'll merge there PRs.

Another very small issue #1492

Check and merge of both PRs should be done in less than 10min

Ninos avatar May 11 '18 11:05 Ninos

@Ninos thanks, I have some time this week (finally) - will take a look at this first :)

jeffikus avatar May 28 '18 14:05 jeffikus

Thank you @jeffikus :-)

BTW: @font-path should also be changed to @font-path: "../fonts"; I've already deleted my branch, so I cannot add changes to this PR :/

Ninos avatar May 28 '18 14:05 Ninos