FlexSlider
FlexSlider copied to clipboard
woocommerce
Add event namespace and destroy method
based upon https://github.com/bradgreens/FlexSlider and tagged version 2.2.2
@jeffikus Any chance destroy function can be merged/added soon since I see you've recently started working like a madman on this project?
I would like to use this in a node-webkit project I'm finishing up and destroy methods are super necessary there to keep memory usage down.
@jeffikus , It will be excellent, If destroy method will be on FlexSlider. It is really important feature.
i'd be happy to have this feature implement too. thanks for the work guys! :)
Hi everyone, have bumped to 2.6.0 release. Haven't had to time to get it into this release. Thanks for your patience!
Has this been added yet? I can't see anything in the documentation about it? Thanks.
Edit: I see it's actually gone back to 2.6.0. Argh. How can I destroy an instance?
It didn't make it in time because not enough priority was put in to making it for 2.6.0. Maybe this should be made higher priority as it's quite a demanded feature. I'd happily accept waiting for any new features for the ability to destroy an instance.
@shipleyr just so you are aware, I've prioritized bugfixes over features this release - If you look at the prioritized features for 2.7.0 you will see the destroy feature is listed as the primary focus, as well as there only being 2 assigned issues for the milestone. In addition I've already started working through those issues/enhancements.
@jeffikus That's good to know. In all honestly I'd have sacrificed some of the bug fixes for this feature. It's killing me having to patch flexslider each upgrade to make it work. I'll eagerly await the next release.
flexslider is only causing headaches! Switched to slick now I am happy and try to forget about the wasted hours.
2.7.0 release is taking some time, so moving this into 2.6.1 fix release for this friday.
@tilwinjoy 2.6.1 was released, as I felt this feature shouldnt delay release any further.
@jeffikus I see. Is there any possibility that if not a full fledged destroy method, just a eventNamespace will be added in the near future?
My usecase is that I wrapped FlexSlider in an AngularJS directive and found out that the combination causes memory leaks while switching routes. So if there's a namespace I could safely do the unbinding without destroying other handlers.
I haven't touched Flexslider in forever (I did the original destroy fork circa 2012). I would agree with @tilwinjoy that the namespace is important, I used namespaces on all my old jQuery projects due to concerns with removing events on elements on a case-by-case basis, where multiple libraries may compete for those events.
That said I realize Flexslider is still popular, at our company we're phasing out jQuery in favor of crisp Angular codebases, so I'm keeping an eye out for solutions which do not depend on "the dollar".
