wong2

Results 551 comments of wong2

i've posted a pr for this: https://github.com/skilldrick/easyforth/pull/5

Related: https://github.com/diegomura/react-pdf/issues/662 https://github.com/vadimdemedes/yoga-layout-prebuilt/issues/2

TLDR: the js file generated by `nbind`(which is used by `yoga` to build javascript lib) is not usable under strict mode.

I thought the build script doesn't bundle `yoga-layout-prebuilt`?

`node-fetch` already throw such an error: `Can't load image /aaa.jpg: Only absolute URLs are supported` Node.js 18: `Can't load image /aaa.jpg: Failed to parse URL from /aaa.jpg`

Following the reproduction steps, I get another error: > Uncaught ReferenceError: process is not defined

I've found the cause: satori depends on `yoga-layout-prebuilt`, which includes a prebuilt version of yoga: https://github.com/vadimdemedes/yoga-layout-prebuilt/blob/master/yoga-layout/build/Release/nbind.js#L33 (warning: file is large). The code checks if the running environment is node with...

@shuding The `yoga-layout-prebuilt` build is too old, which is outdated, I think it's time to maintain a new prebuilt package of yoga-layout.

this bothers me either, now I have to tell everyone using my library to add an empty config in their project, instead of relying on the default behavior