react-native-pdf icon indicating copy to clipboard operation
react-native-pdf copied to clipboard

iOS New Architecture/Fabric build error: no member named 'enableDoubleTapZoom'

Open timbocole opened this issue 1 year ago • 5 comments

What react-native version are you using? RN0.74.0

What react-native-pdf version are you using? v6.7.5

What platform does your issue occur on? (android/ios/both) ios

Describe your issue as precisely as possible : Building with New Architecture enabled/Fabric results in compilation error.

app/node_modules/react-native-pdf/ios/RNPDFPdf/RNPDFPdfView.mm:139:42: error: no member named 'enableDoubleTapZoom' in 'facebook::react::RNPDFPdfViewProps'
    if (_enableDoubleTapZoom != newProps.enableDoubleTapZoom) {
                                ~~~~~~~~ ^
app/node_modules/react-native-pdf/ios/RNPDFPdf/RNPDFPdfView.mm:140:41: error: no member named 'enableDoubleTapZoom' in 'facebook::react::RNPDFPdfViewProps'
        _enableDoubleTapZoom = newProps.enableDoubleTapZoom;

timbocole avatar Apr 26 '24 16:04 timbocole

I was having the same problem

@timbocole fix solved for me

keuvy avatar May 03 '24 13:05 keuvy

Here's a patch, apply it with patch-package:

react-native-pdf+6.7.5.patch

oidoug avatar Jun 04 '24 20:06 oidoug

Resolved by my PR #832 however will leave this issue open until it is included in a published release

timbocole avatar Jun 04 '24 23:06 timbocole

Cool, the patch works on my end!

hahtml avatar Jun 05 '24 09:06 hahtml