react-native-orientation-locker icon indicating copy to clipboard operation
react-native-orientation-locker copied to clipboard

feat(android/ios): support new arch

Open ngocle2497 opened this issue 1 year ago • 9 comments

Migrate Android/IOS to new arch

ngocle2497 avatar May 09 '24 16:05 ngocle2497

Hi @wonday can u review this PR

ngocle2497 avatar May 10 '24 17:05 ngocle2497

@ngocle2497 i am using the library and getting error while rotating screen on IOS 16, Do you have any solution please help me!

taongocson avatar May 22 '24 08:05 taongocson

@ngocle2497 i am using the library and getting error while rotating screen on IOS 16, Do you have any solution please help me!

what the error?

ngocle2497 avatar May 22 '24 15:05 ngocle2497

please fix the conflict

wonday avatar Jun 05 '24 09:06 wonday

I guess this PR description can also have a line with Closes #272 added to it

karlhorky avatar Jun 19 '24 16:06 karlhorky

iOS works well. (first moment it doesn't work but it was my project's misconfiguration in Info.pList) However, android has error.

e: file:///home/runner/work/vscore-rn/vscore-rn/node_modules/react-native-orientation-locker/android/src/main/java/com/orientationlocker/OrientationLockerModule.kt:28:1 Class 'OrientationLockerModule' is not abstract and does not implement abstract base class member public abstract fun removeListeners(count: Double): Unit defined in com.orientationlocker.OrientationLockerSpec
e: file:///home/runner/work/vscore-rn/vscore-rn/node_modules/react-native-orientation-locker/android/src/main/java/com/orientationlocker/OrientationLockerModule.kt:277:3 'removeListeners' overrides nothing

Here is the error when install the branch and call gradlew assembleRelease in android project.

I installed your repository like this.

In package.json,

    "react-native-orientation-locker": "github:ngocle2497/react-native-orientation-locker#feat/new_arch",

leo6104 avatar Oct 05 '24 08:10 leo6104

@leo6104 Ios also works fine for me and android have the same issues. have you find any solutions ?

shubham-ghanghotia avatar Oct 15 '24 14:10 shubham-ghanghotia