react-native-orientation-locker icon indicating copy to clipboard operation
react-native-orientation-locker copied to clipboard

lockToLandscapeLeft is not working for iOS at react-native 0.70.x

Open jihokim2 opened this issue 2 years ago • 10 comments

React-native 0.70.X IOS If I try lockToLandscapeLeft, app is stop.

Could you fix this?

Message is like this.

unrecognized selector sent to instance 0x600001b0d860"

At react-native 0.69.6 It's not working too.

I think https://github.com/facebook/react-native/commit/7d42106d4ce20c644bda4d928fb0abc163580cee is related this issue.

jihokim2 avatar Oct 27 '22 15:10 jihokim2

At react-naitive 0.69.6 and I tried debug mode and after [Orientation setOrientation:mask] the app is finished forced. I tried to find the problem, but I can't find this problem. Plz fix this problem.

jihokim2 avatar Oct 29 '22 02:10 jihokim2

Out of curiosity, did you replace AppDelegate.m with AppDelegate.mm when you upgraded React Native? If so you should add all customizations from the original AppDelegate in order to make sure it still works.

johnbodenhamer avatar Nov 30 '22 22:11 johnbodenhamer

I switched swift file. And I don't use RCT_NEW_ARCH_ENABLED. And I think other customizations is setting. until 0.69.5, It works very well.

jihokim2 avatar Dec 01 '22 02:12 jihokim2

can you confirm if its working in ios 14+ "react-native-orientation-locker": "^1.5.0", "react": "17.0.1", "react-native": "0.64.1",

pawansharmaAccolite avatar Dec 06 '22 13:12 pawansharmaAccolite

@pawansharmaAccolite I tested IOS 16. And At react-native below 0.69.6 It works very well. It does not work just above 0.69.6.

jihokim2 avatar Dec 06 '22 13:12 jihokim2

@pawansharmaAccolite I tested IOS 16. And At react-native below 0.69.6 It works very well. It does not work just above 0.69.6.

can you check in real ios device which have ios 14 or 15 its working or not ?

pawansharmaAccolite avatar Dec 06 '22 13:12 pawansharmaAccolite

@pawansharmaAccolite Yes, but app is dead.

jihokim2 avatar Dec 06 '22 13:12 jihokim2

@jihokim2 you don't received this error with xcode 14.1

[Orientation] BUG IN CLIENT OF UIKIT: Setting UIDevice.orientation is not supported. Please use UIWindowScene.requestGeometryUpdate(_:)

pawansharmaAccolite avatar Dec 06 '22 14:12 pawansharmaAccolite

Probably related and potential fix: https://github.com/wonday/react-native-orientation-locker/pull/243

wouterds avatar Jan 19 '23 11:01 wouterds

@wouterds I tried this already, But this bug is not fixed

jihokim2 avatar Feb 02 '23 04:02 jihokim2