tracy icon indicating copy to clipboard operation
tracy copied to clipboard

Fix MinGW build

Open mncat77 opened this issue 1 year ago • 3 comments

@wolfpld: Just made changes to fix the build for now, should probably not be merged until it is tested properly - is there a standard procedure for that already? Feel like the __except1 macro control flow also needs to be checked, seems a bit iffy.

mncat77 avatar Oct 20 '24 14:10 mncat77

should probably not be merged until it is tested properly - is there a standard procedure for that already?

There is nothing formalized for that.

wolfpld avatar Oct 20 '24 14:10 wolfpld

should probably not be merged until it is tested properly - is there a standard procedure for that already?

There is nothing formalized for that.

Alright, will see if I can find more time to test this properly, should probably not be merged until it is tested properly by someone.

mncat77 avatar Oct 20 '24 14:10 mncat77

This PR doesn't work for me 100%. The __try1 stuff is broken with the zig compiler toolchain. I believe we will want to simply disable this "safe" approach via an option in CMake. The other fixes are good.

mcourteaux avatar Jan 30 '25 17:01 mcourteaux

Fixed by #1078

wolfpld avatar Jun 19 '25 19:06 wolfpld