tracy icon indicating copy to clipboard operation
tracy copied to clipboard

`vkCmdResetQueryPool` called in `TracyVkCollect` despite using `VK_EXT_host_query_reset`

Open maxime-modulopi opened this issue 9 months ago • 2 comments

vkCmdResetQueryPool is called instead of vkResetQueryPool in TracyVkCollect even when the context was created with TracyVkContextHostCalibrated: https://github.com/wolfpld/tracy/blob/f14ff2b994dac1de1d99acfcdced4e9dced47d97/public/tracy/TracyVulkan.hpp#L328

I believe forcing the "Cmd" variant is not needed here?

Also, this would allow removing the cmdbuf parameter of TracyVkCollect when host query reset are used, making it more flexible in when it is called.

maxime-modulopi avatar May 27 '25 11:05 maxime-modulopi

vkCmdResetQueryPool is Vulkan 1.0, vkResetQueryPool is 1.2. Before you ask, Android.

wolfpld avatar Jun 07 '25 11:06 wolfpld

Yes but Tracy already supports creating a TracyVkCtx with host resets via TracyVkContextHostCalibrated (which already calls vkResetQueryPool in its constructor).

Similarly to this, I would have expected to be able to use vkResetQueryPool inside TracyVkCollect too (only if the context was created via TracyVkContextHostCalibrated obviously).

maxime-modulopi avatar Jun 07 '25 13:06 maxime-modulopi