wolfictl icon indicating copy to clipboard operation
wolfictl copied to clipboard

wolfictl check update github release checker should support full semver for pre-releases

Open pnasrat opened this issue 1 year ago • 1 comments

For example Python PEP 440 uses pre-release identfiers including a and b

These are compatible with semver but not excluded when wolfictl check update is run

Currently the githubrelease checker uses []string{"alpha", "beta", "rc", "pre"}

https://github.com/wolfi-dev/wolfictl/blob/dc84d81b0556e732b9f8991406b37d017a4c61aa/pkg/update/githubReleases.go#L559

Semver defines pre-releases as

A pre-release version MAY be denoted by appending a hyphen and a series of dot separated identifiers immediately following the patch version. Identifiers MUST comprise only ASCII alphanumerics and hyphens [0-9A-Za-z-]. Identifiers MUST NOT be empty. Numeric identifiers MUST NOT include leading zeroes.

  • https://semver.org/spec/v2.0.0.html#spec-item-9
  • https://semver.org/spec/v2.0.0.html#backusnaur-form-grammar-for-valid-semver-versions

pnasrat avatar Jun 17 '24 18:06 pnasrat

cc: @rawlingsj

luhring avatar Jun 17 '24 20:06 luhring