os icon indicating copy to clipboard operation
os copied to clipboard

py3-attrs split out for versions add deps

Open justinvreeland opened this issue 1 year ago • 4 comments

This splits py3-attrs into multiple python3 versions and adds the hatch-fancy-pypi-readme package which is an attrs dep.

Fixes:

Related:

Pre-review Checklist

For new package PRs only

  • [X] This PR is marked as fixing a pre-existing package request bug
    • [X] Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • [X] REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • [X] REQUIRED - The version of the package is still receiving security updates
  • [ ] This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • [X] The upstream project actually supports multiple concurrent versions.
  • [X] Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • [X] The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)
  • [ ] If non-streamed package names no longer built, open PR to withdraw them (see WITHDRAWING PACKAGES)

For package updates (renames) in the base images

When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)

  • [ ] REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk images successfully build
  • [ ] REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk contain no obsolete (no longer built) packages
  • [ ] Upon launch, does apk upgrade --latest successfully upgrades packages or performs no actions

justinvreeland avatar Aug 16 '24 17:08 justinvreeland

If non-streamed package names no longer built, open PR to withdraw them (see WITHDRAWING PACKAGES)

A package is still produced but it's empty not sure if I need to do anything here.

@pnasrat I can't assign people to PRs so tagging instead.

justinvreeland avatar Aug 16 '24 17:08 justinvreeland

@justinvreeland don't withdraw packages as the provider priority does the right thing.

Looks like the tests are failing

2024/08/16 17:54:06 INFO using python /usr/bin/python3.12
2024/08/16 17:54:06 WARN Traceback (most recent call last):
2024/08/16 17:54:06 WARN   File "<string>", line 1, in <module>
2024/08/16 17:54:06 WARN ModuleNotFoundError: No module named 'attrs'
2024/08/16 17:54:06 INFO /usr/bin/python3.12 -c "import attrs": FAIL
2024/08/16 17:54:06 INFO pod 

pnasrat avatar Aug 16 '24 21:08 pnasrat

Updated to match: https://github.com/wolfi-dev/os/pull/26761

justinvreeland avatar Aug 20 '24 22:08 justinvreeland

@pnasrat

That LGTM is marked as a requested change for some reason but I dont' seem to be able to resolve it, presumably because I haven't pushed a new version.

justinvreeland avatar Aug 22 '24 23:08 justinvreeland