wolfssl icon indicating copy to clipboard operation
wolfssl copied to clipboard

Use only the first 64 bytes of hash output in fips-hash.sh

Open lealem47 opened this issue 1 month ago • 1 comments

Description

Adjust the fips-hash.sh script to only take the first 64-bytes of the sed output to account for an inconsistency in the FIPS callback for module v5.2.0.1

Testing

./fips-check.sh linuxv5-RC12 keep

Checklist

  • [ ] added tests
  • [ ] updated/added doxygen
  • [ ] updated appropriate READMEs
  • [ ] Updated manual and documentation

lealem47 avatar Nov 19 '25 22:11 lealem47

🛟 Devin Lifeguard found 1 likely issues in this PR

  • check-all-return-codes snippet: Verify whether fips-check.sh is executed with ‘set -e’; if not, wrap the call in ‘if ! ./fips-hash.sh; then echo "fips-hash failed"; exit 1; fi’ (or equivalent) to handle its return code explicitly.

@lealem47 please take a look at the above issues which Devin flagged. Devin will not fix these issues automatically.

Jenkins retest this please

lealem47 avatar Dec 12 '25 17:12 lealem47