wolfssl icon indicating copy to clipboard operation
wolfssl copied to clipboard

Introduce sm-cipher workflow tests to wolfssl

Open gojimmypi opened this issue 4 months ago • 5 comments

Description

This PR introduces SM ShangMi cipher tests in GitHub workflow for the wolfssl repo.

~~The SM TLS 1.3 is currently not working properly; Thus this PR can be merged as-is to show that, or wait until #9175 is merged. I could also temporarily disable the TLS 1.3 tests in this PR.~~

See sample action history: https://github.com/gojimmypi/wolfssl/actions/workflows/sm-cipher.yml

~~(failing as expected on current pr-sm-cipher-test but~~ working on espressif-latest-debug with the needed #9175 patch)

See also:

  • https://github.com/wolfSSL/wolfssl/issues/9169
  • https://github.com/wolfSSL/wolfssl/pull/9175
  • https://github.com/wolfSSL/wolfssl/pull/6825
  • https://github.com/wolfSSL/wolfsm/pull/28
  • https://github.com/wolfSSL/wolfssl/pull/9190
  • https://github.com/wolfSSL/wolfssl/issues/9187

I also have a WIP wolfsm companion SM Cipher Test (2 of 2) test. See sample for that. Update: merged in wolfsm #28

~~SM tests are currently failing there in the wolfsm repo as I do not manually apply the needed patch from https://github.com/wolfSSL/wolfssl/pull/9175 .~~ (merged)

Update: Example GitHub Actions Output:

  • https://github.com/wolfSSL/wolfssl/actions/runs/17931183074/job/50988532573
  • https://github.com/gojimmypi/wolfssl/actions/runs/17931182325/job/50988530803

Fixes zd# n/a

Testing

Tested on my branches:

  • https://github.com/gojimmypi/wolfssl/actions/workflows/sm-cipher.yml
  • https://github.com/gojimmypi/wolfsm/actions/workflows/sm-cipher.yml

Checklist

  • [x] added tests
  • [ ] updated/added doxygen
  • [ ] updated appropriate READMEs
  • [ ] Updated manual and documentation

gojimmypi avatar Sep 12 '25 19:09 gojimmypi

@gojimmypi does this need rebased after the SM fix was merged? I manually clicked to re-run the SM GitHub action test and it failed at the same location.

JacobBarthelmeh avatar Sep 17 '25 17:09 JacobBarthelmeh

Hi @JacobBarthelmeh - yes, the new sm-cipher.yml workflow needs https://github.com/wolfSSL/wolfssl/pull/9175 in order to run successfully.

Now that it is merged, I've refreshed from upstream and confirmed the new test runs successfully in this PR.

gojimmypi avatar Sep 17 '25 17:09 gojimmypi

Jenkins retest this please.

For org.jenkinsci.plugins.workflow.support.steps.AgentOfflineException: Unable to create live FilePath for wolf-linux-cloud-node-[n]; wolf-linux-cloud-node-[n] was marked offline: Connection was broken

gojimmypi avatar Sep 17 '25 19:09 gojimmypi

The SM Cipher test over in wolfsm repo should be nearly identical to this one.

After code review there, I've updated the sm-cipher.yml in this PR with those changes.

gojimmypi avatar Sep 22 '25 23:09 gojimmypi

Jenkins retest this please

For StreamCorruptedException: invalid stream header: 636F7272 at java.base/java.io.ObjectInputStream.readStreamHeader(ObjectInputStream.java:958)

gojimmypi avatar Sep 23 '25 01:09 gojimmypi