wolfssl icon indicating copy to clipboard operation
wolfssl copied to clipboard

Let script setup.sh exit 0 when job is done

Open syncom opened this issue 1 year ago • 1 comments

Description

When the ESP-IDF setup process terminates successfully, it seems more intuitive to let the script "setup.sh" exit 0 to indicate success. It would also help avoid breakage when invoking the script in automation.

Testing

Run the following commands

source /PATH/TO/ESP-IDF/export.sh
cd wolfssl/IDE/Espressif/ESP-IDF/
./setup.sh
echo $? # Should return 0 

Checklist

  • [ ] added tests
  • [ ] updated/added doxygen
  • [ ] updated appropriate READMEs
  • [ ] Updated manual and documentation

syncom avatar Oct 10 '24 21:10 syncom

Can one of the admins verify this patch?

wolfSSL-Bot avatar Oct 10 '24 21:10 wolfSSL-Bot

Since the PR has been open for a while, I'd like to send a friendly reminder. @douzzer , I saw you committed to this file recently - would you be able to take a look at this change? TIA!

syncom avatar Nov 01 '24 15:11 syncom

Hi @syncom -- the git blame for me was coincidental and only for the first line. I've looped in one of our ESP-IDF experts, @gojimmypi , to check more widely to see if there are other instances of this in the IDE/Espressif/ tree.

Have you signed a contributor agreement with us? For a change this small, it is not important, but good to know,.

douzzer avatar Nov 01 '24 22:11 douzzer

Hi @syncom -- the git blame for me was coincidental and only for the first line. I've looped in one of our ESP-IDF experts, @gojimmypi , to check more widely to see if there are other instances of this in the IDE/Espressif/ tree.

Thanks!

Have you signed a contributor agreement with us? For a change this small, it is not important, but good to know,.

No. I don't mind signing a contributor agreement if need be, but I have a slight preference not to sign anything.

syncom avatar Nov 01 '24 22:11 syncom

Hi @syncom and thanks again for your suggestion.

@dgarske merged https://github.com/wolfSSL/wolfssl/pull/8189 that addresses the incorrect exit error code at the end of ESP-IDF/setup.sh.

I'm assuming that this topic is resolved & will close this PR. If you encounter any problems or would like any further assistance, please do not hesitate to reach out.

Best Regards

Jim

p.s. If you'd like to share the details project you are working on, I'm always looking for ideas to blog about how wolfSSL is used in Espressif projects.

gojimmypi avatar Nov 15 '24 21:11 gojimmypi