Feature/multiple aes siv ads

[ptsiewie]

Description

The AES SIV algorithm implementation in WolfSSL would accept only exactly one vector of associated data, even though the definition of the algorithm of RFC5297 allows any number no larger than 126.

Fixes zd#18509

Testing

The tests in test.c have been extended to include the two examples given in the RFC5297 document. The second of these two examples uses two ADs.

Checklist

• [x] added tests
• [ ] updated/added doxygen
• [ ] updated appropriate READMEs
• [ ] Updated manual and documentation

[wolfSSL-Bot]

Can one of the admins verify this patch?

[dgarske]

Okay to test. Contributor agreement in progress.

[dgarske]

Okay to test. Contributor agreement in progress. @ptsiewie sorry for the delay in getting your agreement approved. Expect it next week.

[SparkiDev]

The old API goes through the new API so we will always include code.

[SparkiDev]

Hi @ptsiewie

Errors in ctidy check

TLDR: change '1u' to '1U'

Error: shellcheck configure.../var/lib/jenkins/workspace/PRB-multi-test-script/wolfssl/wolfcrypt/src/aes.c:13850:43: warning: integer literal has suffix 'u', which is not uppercase [readability-uppercase-literal-suffix] return AesSivCipher(key, keySz, &ad0, 1u, nonce, nonceSz, in, inSz, ^~ U /var/lib/jenkins/workspace/PRB-multi-test-script/wolfssl/wolfcrypt/src/aes.c:13864:43: warning: integer literal has suffix 'u', which is not uppercase [readability-uppercase-literal-suffix] return AesSivCipher(key, keySz, &ad0, 1u, nonce, nonceSz, in, inSz, ^~ U

[dgarske]

Okay to test. Retest this please

[dgarske]

Reminder, contributor agreement in progress, but not yet approved. Person needed for that is on vacation this week.

[dgarske]

Contributor agreement approved and on file. Thank you @ptsiewie!

[ptsiewie]

Do I need to do something before this branch will be merged?

[dgarske]

Hi @ptsiewie ,

Thank you for your work on this. I have merged it. Sorry about the delay.

Thanks, David Garske, wolfSSL