wolfssl
wolfssl copied to clipboard
wolfSSL
`InitSuites` changes to order making `BUILD_TLS_AES_256_GCM_SHA384` be prioritized over `BUILD_TLS_AES_128_GCM_SHA256`
Description
internal.c - InitSuites changes to order making BUILD_TLS_AES_256_GCM_SHA384 be prioritized over BUILD_TLS_AES_128_GCM_SHA256 to match TLS 1.2 order.
-fix for test quic.c, api.c, and test.h hard coded size assumption.
-fix ssl.c TRUE/FALSE to 1/0.
Testing
./configure --enable-all --enable-debug --disable-shared
make
make check
@aidangarske its just the python port that is failing now. it has a check expecting 32 and its now 48.
======================================================================
FAIL: test_tls_unique_channel_binding (test.test_ssl.ThreadedTests)
Test tls-unique channel binding.
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/workspace/PRB-python-port/osp/Python/Python-3.8.14/Lib/test/test_ssl.py", line 4204, in test_tls_unique_channel_binding
self.assertEqual(len(cb_data), 32)
AssertionError: 48 != 32
----------------------------------------------------------------------
Ran 163 tests in 10.657s
FAILED (failures=1, skipped=18)
1 test failed again:
test_ssl
If you can fix in OSP repo and put up a PR and reference this we can merge it after we merge this one.
NOTE: This PR could potentially cause issues for some customers, so we may need to add an option to support the old behavior. I'd also really like to get @SparkiDev to review this change.
