wolfssl icon indicating copy to clipboard operation
wolfssl copied to clipboard

Add wolfSSL_PEM_read_RSAPrivateKey to OpenSSL compatible API

Open satoshiyamaguchi opened this issue 3 years ago • 3 comments

Description

This PR adds wolfSSL_PEM_read_RSAPrivateKey() to the OpenSSL compatible API, and adds the unit-test code to tests/api.c .

wolfSSL_PEM_read_RSAPrivateKey() was added from line 1782 to line 1822. #ifdef is on line 1346. #endif is on line 2062.

Testing

Built example app using wolfSSL_PEM_read_RSAPrivateKey() and ran it. Checked if wolfSSL_PEM_read_RSAPrivateKey() returns RSA structure and if RSA_print_fp() can print the RSA structure.

Checklist

  • [x] added tests
  • [ ] updated/added doxygen
  • [ ] updated appropriate READMEs
  • [ ] Updated manual and documentation

satoshiyamaguchi avatar Aug 03 '22 14:08 satoshiyamaguchi

Can one of the wolfSSL admins verify this patch?

wolfSSL-Bot avatar Aug 03 '22 14:08 wolfSSL-Bot

OK to test . @satoshiyamaguchi is a contractor.

dgarske avatar Aug 03 '22 14:08 dgarske

@dgarske I fixed the cause of the error. Thank you.

satoshiyamaguchi avatar Aug 05 '22 15:08 satoshiyamaguchi

Retest this please jenkins

cconlon avatar Aug 12 '22 17:08 cconlon

I fixed the part that seemed to be the cause of the error.

satoshiyamaguchi avatar Aug 16 '22 15:08 satoshiyamaguchi

Contributor agreement filed and approved.

cconlon avatar Aug 17 '22 23:08 cconlon