Add BIO_sock_should_retry and BIO_sock_non_fatal_error to OpenSSL compatibility layer

Open darktohka opened this issue 3 years ago • 5 comments

Description

BIO_sock_should_retry and BIO_sock_non_fatal_error are not currently implemented inside the OpenSSL compatibility layer.

BIO_sock_should_retry is used to check whether the last socket operation has resulted in a fatal error or not, and if a retry (as such) is advised or not.

To make it possible to implement BIO_sock_should_retry without code reuse, I've taken the liberty of making wolfSSL_LastError a public function, available in the wolfio.h header. Thanks to this change, examples/server/server.c no longer needs its own definition of wolfSSL_LastError either.

Testing

I've created a new test case, based on the BIO_should_retry test case. It completes successfully. The application I'm porting to WolfSSL also works fine with the change.