wolfssh icon indicating copy to clipboard operation
wolfssh copied to clipboard

Error when building wolfssh with only WOLFSSH_NO_ECDSA or WOLFSSH_NO_ECDH

Open oleg35hp opened this issue 1 year ago • 2 comments

wolfssh/internal.h:598

#if !defined(WOLFSSH_NO_ECDSA) && !defined(WOLFSSH_NO_ECDH)
        ecc_key ecc;
#endif

should be

#if !defined(WOLFSSH_NO_ECDSA) || !defined(WOLFSSH_NO_ECDH)
        ecc_key ecc;
#endif

oleg35hp avatar Apr 19 '24 23:04 oleg35hp

I'm taking a look at this. I see a few inconsistencies and errors in the preprocessor guards. Thanks for the feedback.

ejohnstown avatar Apr 30 '24 17:04 ejohnstown

The actual solution is to check for #ifndef WOLFSSH_NO_ECDH. I have a fix in the works, and I'll link it where when it is a PR.

ejohnstown avatar Apr 30 '24 21:04 ejohnstown