gremlin-rs icon indicating copy to clipboard operation
gremlin-rs copied to clipboard

Feature/trim native tls and features

Open mlemesle opened this issue 2 years ago • 2 comments

Supersedes #184

Closes #176 and #180

Hey there, I started again and successfully trimed native-tls from the dependencies and moved tokio-native-tls to rustls-webpki. All tests pass for async-std and tokio-runtime !

There is still some work to do:

  • Adapt Connectors configuration to rustls
  • Trim other dependencies
  • Rework the features => move async_gremlin to __async_gremlin, to show developers not to use it

I also added a compilation failure if someone tries to use async-std-runtime and tokio-runtime at the same time.

What do you think of this ?

mlemesle avatar Apr 07 '23 15:04 mlemesle

@mlemesle

looks great, just one thing, why the tungstenite dep is via github? is it missing something there yet not released?

wolf4ood avatar Apr 07 '23 16:04 wolf4ood

I forgot to mention. There was a lot of dep version issues. I had to fork 3 dependencies in order to fix this... PR are submitted, I'm waiting for a release to add it to Cargo.toml!

What about my previous points? Like moving async_gremlin to __async_gremlin?

mlemesle avatar Apr 07 '23 16:04 mlemesle