David Wolever

Results 56 comments of David Wolever

Hey folks! Sorry for the delay here. I'd love to have type hint support, and would be more than happy to help get a PR working (although I confess I'm...

Good news, @adamchainz! Python 2 support is dropped in 0.9! I haven't removed all the compat code yet, but if you can point me in the right direction for how...

Thanks for the PR! I'm not sure I'm familiar with this functionality, what will it do?

Weird. I can't recreate that on any of the supported Pythons (2.7, 3.3, PyPy). What's in the set?

Disregard that, I'm an idiot. The issue is that sets can't be compared to non-set things. Testing for this also uncovered a related issue: python 3 gets fussy when trying...

Okay! I've put https://github.com/wolever/safesort out there for comments, and I'll use it for sorting here too once I've got some confirmation that it's not a totally insane thing to do.

On 2014-09-10, at 1:56 PM, Jonathan Slenders [email protected] wrote: > ok, nice. :) > btw, is it impossible to establish without the exec in safesort? > > Ya, safesort would...

On 2014-09-10, at 3:23 PM, Jonathan Slenders [email protected] wrote: > No real concern, it could be a valid use case. Only it feels like going back in time and have...

Hey! Thanks for the PR! Two things: 1. The default should be `False` on Py3 (as dicts are already ordered) and the documentation should reflect this 2. Please add tests,...

Oof good catch. I don't have the cycles to write a fix right now, but would be very happy to review a PR!