DB Value escaping

[benwaine]

Currently no escaping.

Have to think how to implement this / also is it necessary.

Not a customer facing?

[glenjamin]

I think it makes sense to leave doctrine / the abstract concept of a datasource to be repsonsible for this bit.

[marijn]

I agree with @glenjamin seems to me that is the responsibility of a database abstraction layer.

[benwaine]

Unfortunately DBAL doesn't escape values automatically. This would require more meta data about the values in question than is available to the DBAL.

Doctrine ORM can achieve auto escaping because each table is described in xml, ymal or PHP annotations.

[benwaine]

Damm tat comment and close button is to close to just 'close' :D

[glenjamin]

The inputs are all known, so I guess this isn't really much of a problem. If there are any fields/values which need to be escaped then the test implementor could use a transformation.

[everzet]

@benwaine first, you need to extract DB-oriented logic into separate interface. All escaping should happen here. For example, you have 2 connection interface implementations:

1. DoctrineDbalConnection - will escape all it's values before updating/inserting
2. DoctrineOrmConnection - will not do anything with values, as it's ORM job in this case

[benwaine]

As part of the data source abstraction I have moved Doctrine DBAL into a separate adapter implementing a data source interface.

I'll be able to add the escaping in at this point.