react-lifecycle-methods-diagram icon indicating copy to clipboard operation
react-lifecycle-methods-diagram copied to clipboard

Published 20 hours ago • verified publisher icon wojtekmaj

"Show less common lifecycles" shows more lifecycles - confusing wording

Open wojtekmaj opened this issue 6 years ago • 6 comments

As reported in #2, wording is confusing.

"Show less common lifecycles" means "Show me also those lifecycles which are less common" and NOT "Show me less lifecycles".

wojtekmaj avatar Apr 07 '18 14:04 wojtekmaj

Hello!

I send pull request #4 to fixing this issue.

igorkamyshev avatar Apr 10 '18 03:04 igorkamyshev

Maybe `Show me the less common lifecycles" is a better choice for this? :thinking:

klujanrosas avatar Apr 10 '18 23:04 klujanrosas

That would work too! @TheNovel suggested "Show me all lifecycles" and I came up with "Show also less common lifecycles" .

wojtekmaj avatar Apr 10 '18 23:04 wojtekmaj

"Show less-common lifecycles"

samvk avatar Apr 11 '18 06:04 samvk

Maybe close this issue? PR already sent.

igorkamyshev avatar May 17 '18 07:05 igorkamyshev

"Show all lifecycles" is perfect.

manuel-di-iorio avatar Nov 16 '18 18:11 manuel-di-iorio