react-date-picker icon indicating copy to clipboard operation
react-date-picker copied to clipboard

chore: remove unnecessary `declare module` block in typings

Open JounQin opened this issue 1 year ago • 3 comments

The typings are in its own package, so declare module is redundant.

JounQin avatar Jul 19 '22 18:07 JounQin

ping @wojtekmaj

JounQin avatar Jul 25 '22 14:07 JounQin

In this case, what about entry.nostyle.d.ts?

wojtekmaj avatar Jul 25 '22 14:07 wojtekmaj

In this case, what about entry.nostyle.d.ts?

@wojtekmaj

It is not types in package.json, or the same dir as dist/entry.nostyle .js, so its declare module is required, and this PR will not break that.

Personally, I would prefer to have entry.nostyle.d.ts at dist/entry.nostyle.d.ts, then no declare module is required.

JounQin avatar Jul 25 '22 15:07 JounQin