Wojciech Maj

Results 338 comments of Wojciech Maj

That is an expected change in v2: https://github.com/ananay/passport-apple/commit/6b8c1ce0fecf6cac2c8a0f669824dc2640fb5112 Please note that TypeScript typings were not updated to reflect this change: https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/66925

And perhaps most importantly, an alternative for deep-equal, which is super bloated because it supports, like, Node 0.0.1 or something.

Supporting one framework's fake timers is one thing, making the library framework-dependent by breaking it for all other testing frameworks is another. This code should NOT be run on non-Jest...

The problem I was aiming to address with Partial is in my opinion bigger than the one reported here, and I don't know if I have a solution to make...

While concerns about Jest/Vitest shared here may be valid, migration to Vitest will bring a clear improvement of our dev environment, and will enable me to proceed with more modernization...

A workaround just to get going further would be to add use Esbuild's `banner.js` setting to inject `const __dirname = new URL('.', import.meta.url).pathname;`.

It looks like after adding this workaround it works just fine. A low hanging fruit to fix? 🧐

What I mean is that it seems __dirname is the only thing breaking ESM compatibility, so just replacing this bit with something else would make it far easier for ESM...

This is kind of working as expected, but it's a common request to allow invalid/incomplete values to be retained. Acknowledged.