Wojciech Maj

Results 257 comments of Wojciech Maj

Yes and no. Keeping old versions in CI prevents usage of any new JS and Node.js features.

Oooooo that's just lovely! Thank you for that! I'll happily release this, but in the next major, as this change might end up being very impactful on people's UIs. Also,...

That looks good to me! My point stands though - I'll be merging this in the next major release. :) Thanks!

Hey, regarding png-js bit - consider pngjs too! See my comment: https://github.com/diegomura/react-pdf/issues/676#issuecomment-1930922597

Would be fantastic to also talk to: * GitHub * Gitlab * Azure DevOps * npm, Yarn, pnpm maintainers to update the defaults set as you create repo with them.

Another example is testing functions with side effects. ```ts describe('handleNumber()', () => { it('should convert 1 string to a number', () => { const args = { foo: '1' };...

If you look at vitest's types, it actually inherits type from whatever's passed to it: ```ts interface JestAssertion extends jest.Matchers { toEqual(expected: E): void; toStrictEqual(expected: E): void; toBe(expected: E): void;...