req

req copied to clipboard

Difference in (url encoding) behaviour compared with HTTPoison

15

While migrating a part of our snapshot crawler (https://github.com/etalab/transport-site/pull/3585), I did some largish scale testing, comparing the behaviour of HTTPoison and Req in detail. One thing that came out is...

thbar

Ref: https://github.com/livebook-dev/livebook/pull/2497/files

wojtekmach

Default `into: ""`?

2

Note to self: check `defp supported_accept_encoding`.

wojtekmach

I keep forgetting this is not a thing and needs to be `headers: [accept: "application/json"]`. If we do this we could remove `range` step in favour of setting `headers: [range:...

wojtekmach

Add `Req.add_request_steps/3` and friends

5

Currently we have have pairs of append and prepend functions for each type of steps, `Req.Request.append_request_steps/2`, `Req.Request.prepend_request_steps/2`, ... My idea of `Req` and `Req.Request` separation is the former is what...

wojtekmach

v1.0 checklist

3

- [ ] https://github.com/swoosh/swoosh/pull/830/files#diff-e3dca7da1dc26f78c6942e408e806dd74956ef02fe0d75ff3ce1ddd3d319f52aR27 - [ ] https://github.com/ex-aws/ex_aws/blob/main/lib/ex_aws/request/http_client.ex#L10

wojtekmach

Clarification and potential issue with `:verify_checksum` response step

1

Hi @wojtekmach! Firstly, I wanted to express my gratitude for Req, which has been immensely useful. I'm reaching out to better understand the intended use cases for the `:checksum` step...

rhcarvalho

New step: Log request/response

8

TBD the naming and output formatting but basically we want to dump the raw request and response for debugging. Something like this: It's using logger so that users can enable...

wojtekmach

`encode_body`: Set HTTP method to POST on :body/:form/:json

2

wojtekmach

Before: ```elixir Req.post!(req, url: "/prices", form: [ product: product.id, unit_amount: 100, currency: "usd", "recurring[interval]": "month" ] ) ``` After: ```elixir Req.post!(req, url: "/prices", form: [ product: product.id, unit_amount: 100, currency:...

wojtekmach