Wojtek Mach

Results 381 comments of Wojtek Mach

I hope to finish it in the next week or two, sorry for the delay.

Closing in favor of #4618, thanks everyone for feedback and apologies for delay!

Req.Test.passthrough unfortunately won’t work because users would already have set: plug: {Req.Test, name} and so it is too late to opt-out of using plug.

I suppose we could make it work but it would be really really hacky. (We’d store in private the adapter people might have set and in run_plug/1 _adapter_ we check...

> Another option would be to just support :passthrough | plug, which while restrictive, I still think covers really most use cases. not sure what you mean, can you elaborate?...

Of course something closer to what we have right now would totally work too, I'm totally fine special casing `adapter: {:test, name}`: ```elixir # config/test.exs config :myapp, foo_req_options: [adapter: {:test,...

There is no way to bring back the old behaviour at the moment. I'll consider reverting or making this configurable.

@sneako actually let's hold off on this for a second, perhaps we should set Mint version requirement to `>= 1.6.1` so we always pick a Mint which would use OS...

The failing line is this one: https://github.com/sneako/finch/blob/047a4177a8061ba971fb8398bfd7718554091300/test/finch/http2/pool_test.exs#L239 I have determined it started failing after this Mint change, https://github.com/elixir-mint/mint/pull/434, which makes sense, Mint stopped sending frames under some circumstances and the...

No worries, thanks for the ping, we're keen on moving forward with this.