Wojtek Mach

Results 366 comments of Wojtek Mach

Oh so we’d ensure we are before any of these given steps? That’s an interesting approach. I’d like to see more use cases for :before/:after. Ie if we allow a...

yeah, the `var versionNodes = ` format is straightforward but yes, I agree it should be documented. Perhaps the location was configured at some point but right now I see...

For ExDoc itself, it seems it can be without `v`, ```diff ~/src/ex_doc[main]$ git diff diff --git a/mix.exs b/mix.exs index 306d848f..e2731be2 100644 --- a/mix.exs +++ b/mix.exs @@ -120,7 +120,7 @@ defmodule...

Hallo! Good call. In "Features" we have > Request body compression and automatic response body decompression (via [compress_body](https://hexdocs.pm/req/Req.Steps.html#compress_body/1), [compressed](https://hexdocs.pm/req/Req.Steps.html#compressed/1), and [decompress_body](https://hexdocs.pm/req/Req.Steps.html#decompress_body/1) steps). And the idea was the word "automatic" is...

Can also be super explicit: ```markdown * Set request body compression with `compress_body: true`. See [compress_body]. * Automatically decompresses response body. Set `decompress_body: false` or `raw: true` to disable. See...

I'd like to keep retries on by default. > but it also means we spend potentially much longer than I'd have originally accounted for to make a request. Yup, fair...

Python requests has retry by default for network errors (not 500s, for example) but it looks like everyone else has them opt-in. I'll think about it some more but I'll...

> Instead, it would be nice to have more configurability about the transport_opts passed on a per-scheme basis, rather than globally right, I believe you should be able to write...