Wojtek Mach

Results 311 comments of Wojtek Mach

Thanks for the offer, this is slightly more complicated under the hood so I'll keep it for myself. :)

> `Req.Request.register_options(req, aws_sigv4: [update: :replace | :merge])` this choice would prevent us from _validating_ nested option names like: ```elixir Req.Request.register_options(req, aws_sigv4: [:access_key_id, :region, ...]) ``` so need to carefully consider...

Another idea is to have a separate function like `Req.deep_merge/2`.

Note to self, currently: ```elixir iex> Req.new(params: [a: 1], params: [b: 2]).options.params [b: 2] iex> Req.new(params: [a: 1]) |> Req.merge(params: [b: 2]) |> then(& &1.options.params) [a: 1, b: 2] ```

@smaximov thank you for chiming in. I still can't decide on an API so this will take some time. Ideally you should be able to work around this limitation in...

Thank you for the report. This is a playground bug, I'm not yet sure of the root cause but FWIW it works as expected when playground live reload is disabled,...

> This PR allows for running mix release as the LiveReload code is now guarded against if it is explicitly opted out of WDYT about adding an `examples/demo_release/`, a minimal...

opentelemetry_api has docs for both languages: https://hexdocs.pm/opentelemetry_api/OpenTelemetry.Span.html https://hexdocs.pm/opentelemetry_api/otel_span.html So I believe it’s just a matter of configuration.

For anyone running into this issue, please see https://github.com/sneako/finch/pull/273#issuecomment-2144879631, you can test it by setting Finch dependency to: ```elixir {:finch, github: "keathley/finch", branch: "handle-idle-connections", override: true} ```

It means the the request will be retried.