xcode-open-on-github icon indicating copy to clipboard operation
xcode-open-on-github copied to clipboard

Adds my fork url to the start of the url

Open garvankeeley opened this issue 4 years ago • 1 comments

I get 'https://github.com/garvankeeley/firefox-ios%0Dhttps://github.com/mozilla-mobile/firefox-ios/blob/f09af843f5490f58211a3b71d4ac874e92c26b39/Client/Frontend/UserContent/UserScripts/MainFrame/AtDocumentEnd/FindInPage.js%23L66-L66' when this would be the working URL: 'https://github.com/mozilla-mobile/firefox-ios/blob/f09af843f5490f58211a3b71d4ac874e92c26b39/Client/Frontend/UserContent/UserScripts/MainFrame/AtDocumentEnd/FindInPage.js%23L66-L66'

With one other strange problem, the encoded # as %23 doesn't but work # does, which I think might be a Firefox bug, because the URL encoding looks fine to me.

This tool is awesome BTW! I don't mind quickly editing the URL to work, it is still way faster than the fully manual method.

garvankeeley avatar Aug 06 '20 16:08 garvankeeley

I just add a tail -1 after the fetch+awk step to grab my upstream remote.

garvankeeley avatar Aug 07 '20 15:08 garvankeeley