Wojciech Tyczynski
Wojciech Tyczynski
@cblecker - thanks; the announcement have been sent in: https://groups.google.com/a/kubernetes.io/g/leads/c/PYjDxRh8ghQ
/remove-lifecycle stale There are still things to do described in: https://github.com/kubernetes/test-infra/issues/25967#issuecomment-1105612832
> Can you render that as a checklist in the original issue comment so that everyone knows what still needs to be done? Thanks! Done
/lgtm /approve @kubernetes/release-managers - for cherrypick approval
/lgtm /approve @kubernetes/release-managers - for cherrypick approval
Great to see it merged - thanks!
> lgtm but i also share cardinality concerns. > @wojtek-t what do you think? Just to double check I didn't miss anything - it's effectively the exact same metric -...
Couple thoughts from me: > TestCreate uses the etcd client to: Indeed I would switch to storage.Interface.Get instead. Checking invariants about data, I would make a dedicated etcd3-specific test for...
Thinking more about TestGuaranteedObject (and similar cases where we just check simple invariants). Can we pass an additional callback to the test function that will be called (in etcd test...