Lukas Wöhrl

@NickGerleman Hi, I just stumbled over that open issue. As I heavily contributed to https://github.com/facebook/yoga a few years ago, my recommendation would be to use `YGExperimentalFeature*` + `YGConfigSetExperimentalFeatureEnabled` for that,...

Looking at the implementation at: https://github.com/cert-manager/issuer-lib/blob/main/controllers/request_controller.go#L306 I can see that it should be handled differently. I'm replacing the PR with an approach like that: It records the errors as intermediate...

PR is now updated to reflect a similar behaviour as in the https://github.com/cert-manager/issuer-lib, by allowing a grace period of retries.

@dcamzn No I don't know. According to the docs it's only retrying if it's not in a terminal state (marked as failed). I also looked through the source code and...

@dcamzn thanks. One tip to reproduce the issue quite easily: * delete the issuer * request a certificate (it will fail) * create the issuer Expected scenario is that it...

@dcamzn great, thank you! Let me share the following docs about the certificaterequest which states that it's not retrying the issuing after failure: https://cert-manager.io/docs/concepts/certificaterequest/ So I guess the Faq is...

Did some additional research, looks like that any of those conditions do not match, and the `CertificateRequest` is not getting deleted: https://github.com/cert-manager/cert-manager/blob/c6ff0136d2973a4aa14c6c08f86c0e254b1f79c6/pkg/controller/certificates/requestmanager/requestmanager_controller.go#L222-L261

Thank you @divyansh-gupta for investigating, I also have read through the PR, but this is not what I see. I would like to share the exact logs which shows that...

@dcamzn @divyansh-gupta what are your thought on this PR, after syncing with the cert-manager team?

@divyansh-gupta thank you for the update. There must be definitely something wrong somewhere. If you look at my event log, you can clearly see that it retried multiple times and...