Christian Woltering

Results 106 comments of Christian Woltering

> Resolved it in Master. Alright. Now the remaining two issues mentioned above https://github.com/xiaoyeli/superlu/issues/108#issuecomment-1666605067 should be addressed. Regarding the Github workflow: since the CMake build script works pretty well, I'd...

Btw, if you look at the [test output](https://github.com/xiaoyeli/superlu/actions/runs/6141864712/job/16662781913) of the Github workflow, you still see a bunch of segfaults. I strongly suggest that you fix the test setup, so the...

I just tested the cmake workflow here https://github.com/wo80/superlu/commit/e494d2ac8c1bb17d475432273cdf8b60ba6f391a and all tests are passing. @xiaoyeli Please let me know if you want me to merge this into #112 EDIT: I applied...

After merging the upstream changes, the segfault seems to be fixed. But now the "LA" d_tests fail with ``` Subprocess aborted***Exception: 0.15 sec dgstrf info 1 dgstrf info 1 dgstrf...

I think I found the culprit: https://github.com/xiaoyeli/superlu/commit/cf93b7e131d379774a52b184e23548d84eb66e30 https://github.com/xiaoyeli/superlu/blob/90ee45dc836d8f4ff967cad4aa2821809b12fdc9/SRC/dpivotL.c#L134-L146 This was an external contribution merged two days ago. And it's the perfect demonstration, how important a functional CI test setup is....

I rebased #112 and added the changes from my fix/github-workflow branch (now deleted).

I haven't addressed the above issue in `dpivotL.c`. I think it's better you @xiaoyeli fix this in a single commit. Then the workflow shouldn't fail anymore. EDIT: just for demonstration...

https://github.com/xiaoyeli/superlu/commit/f63265a50e6dec635c20f04f7b47e93b0a5c198b seems to fix the issue, the workflow tests are passing. One question remaining, though: Comparing `dpivotL.c` to the `(c|s|z)pivotL.c` variants, the code re-assigning `perm_r[*pivrow]` in the section labelled `/*...

This issue was already mentioned in https://github.com/xiaoyeli/superlu/issues/106#issuecomment-1666831977 . @sagitter Can you check if https://github.com/wo80/superlu/tree/fix/examples-blas-prototypes makes a difference? If it fixes the problem, I'll create a PR. The return type is...

Though the error message is a bit strange ``` /builddir/build/BUILD/superlu-6.0.1/EXAMPLE/cfgmr.c: In function 'cfgmr': /builddir/build/BUILD/superlu-6.0.1/EXAMPLE/cfgmr.c:83:16: error: conflicting types for 'caxpy_'; have 'int(int *, complex *, complex *, int *, complex *,...