aframe-super-hands-component
aframe-super-hands-component copied to clipboard
wmurphyrd
Make Aframe 1.5.0 compatible (remove conflicts with new core component grabbable)
In Aframe 1.5.0 release there was a component added to core called "grabbable". This leads to conflicts with the component of super-hands, which has the same name.
I don't think @dmarcos will want to change the name, the component is included in an aframe release already.
I didn't test, but you should be able to use the following to resolve the issue:
<script src="https://aframe.io/releases/1.5.0/aframe.min.js"></script>
<script>
delete AFRAME.components["grabbable"];
</script>
<script src="https://unpkg.com/super-hands@^3.0.3/dist/super-hands.min.js"></script>
We probably need to rename grabbable to sh-grabbable in this repo to really fix the issue.
@jonarnaldo Do the above code snippet works for you?
I'm not using this component, so I won't work it. But someone can make a PR if we agree on something here. If we rename the grabbable component, we probably want to rename all components hoverable, clickable, grabbable, stretchable, draggable, and droppable. What do you think @wmurphyrd?
I'd also recommend sh-grabbable because SupreHands depends on AFrame, not the other way around. What's the functionality difference though? Are they exactly equivalent or not?
PS: I'd also appreciate @wmurphyrd's view on the topic as he's been thinking on this quite a bit.
jeezus, it took me forever to eventually get to this page, after trying everything to fix my code.
[vincentfretin's solution works 100% I just tested it. It should be at least AT LEAST added to the Super Hands documentation including on the read me underneath Installation, UNTIL we have a new name to replace grabbable, like graspable
It just occurred to me that someone could write a my-super-hands component also that somehow replaces the word grabbable with something else.
