create-react-app-typescript icon indicating copy to clipboard operation
create-react-app-typescript copied to clipboard

Fix peer dependencies for TS 3

Open nickmccurdy opened this issue 5 years ago • 7 comments

TypeScript 3 has been released, and has a small enough number of breaking changes that it shouldn't be too hard for us to officially support. I upgraded to 3.0.1 and it does seem to work well in CRA-TS, but we should probably verify that our dependencies have official TS 3 support.

npm WARN [email protected] requires a peer of typescript@^2.1.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.

Related

  • [x] https://github.com/kulshekhar/ts-jest/issues/643
  • [x] https://github.com/Realytics/fork-ts-checker-webpack-plugin/issues/133

nickmccurdy avatar Jul 30 '18 20:07 nickmccurdy

Thanks for keeping track of these. Seems that updating the plugin might take a while, given that the main author is not that active at the moment.

DorianGrey avatar Aug 01 '18 06:08 DorianGrey

Both packages updated with TS 3 support, I'll publish a PR as soon as I have time to test the new version contraints.

nickmccurdy avatar Aug 04 '18 02:08 nickmccurdy

It seems like TS 3 is now in master, but there are still peer dependency warnings, see #387.

nickmccurdy avatar Sep 01 '18 23:09 nickmccurdy

How to fix these warnings? Can I just ignore them?

Tracis avatar Sep 10 '18 10:09 Tracis

#387 fixes them. For now you should ignore them until it's merged.

nickmccurdy avatar Sep 10 '18 15:09 nickmccurdy

I manually upgraded react-scripts-ts, ts-jest, babel-jest, jest, fork-ts-checker-webpack-plugin, ajv and solved these problems.

Tracis avatar Sep 10 '18 15:09 Tracis

how's this been going?

franklixuefei avatar Jan 02 '19 22:01 franklixuefei