iwxxm icon indicating copy to clipboard operation
iwxxm copied to clipboard

merge FT2025-2 into master after approval

Open amilan17 opened this issue 6 months ago • 6 comments

amilan17 avatar Jun 23 '25 12:06 amilan17

first pass on preparing for the changes that will be published in the Manual on Codes vI.3

amilan17 avatar Jun 23 '25 12:06 amilan17

@blchoy Will you please approve this PR after we have resolved the question about the description of a PATCH version?

amilan17 avatar Jul 25 '25 12:07 amilan17

As a reminder, after approval, we will need to refresh files in the FT2025-2 branch by changing all references to 2025-2RC2 to 2025-2. This involves the replacements of all examples, schemas and schematron rule.

blchoy avatar Aug 08 '25 12:08 blchoy

@blchoy I went through this PR and a comparison of FT2025-2 to 2023-1 release and have some questions on the notes. Can you please review them? If you approve of a "suggestion" - go ahead and merge it.

Two general questions

  1. many of the packages have notes like the following that I could not find in the diffs -- Are these changes introduced in one of the common packages?
  • Revised iwxxm:VocanoObservatoryNoticeForAviation to allow for extension
  • Revised to use codelists http://codes.wmo.int/iwxxm/MeteorologicalFeature and http://codes.wmo.int/iwxxm/nil"
  1. the version attributes in the XSDs that have not changes (except for editorial) do not reference 2025-2RC2, should they?

Thanks for all of your help!

++++++

Choy:

  • Revised iwxxm:VocanoObservatoryNoticeForAviation to allow for extension

Yes, only QVA needs this. I have removed similar bulletin from WAFS SIGWX FC and VONA

  • Revised to use codelists http://codes.wmo.int/iwxxm/MeteorologicalFeature and http://codes.wmo.int/iwxxm/nil"

We only need to change the documentation in the schema. They were there if you look again.

the version attributes in the XSDs that have not changes (except for editorial) do not reference 2025-2RC2, should they?

The versions should always be 2025-2. Only the schemaLocation should point to the real XSD file which is located under .../2025-2RC2/iwxxm.xsd

amilan17 avatar Aug 08 '25 17:08 amilan17

I am done. Please re-check and merge if ok. Thanks.

blchoy avatar Aug 08 '25 18:08 blchoy

the version attributes in the XSDs that have not changes (except for editorial) do not reference 2025-2RC2, should they?

The versions should always be 2025-2. Only the schemaLocation should point to the real XSD file which is located under .../2025-2RC2/iwxxm.xsd

@blchoy Thank you. Just one follow up. The question is about the version attribute in the package XSDs. for e.g. airmet.xsd: > targetNamespace="http://icao.int/iwxxm/2025-2" version="3.1.1" xmlns:iwxxm="http://icao.int/iwxxm/2025-2 vs spaceWxAdvisory.xsd > targetNamespace="http://icao.int/iwxxm/2025-2" version="3.1.0RC2" xmlns:iwxxm="http://icao.int/iwxxm/2025-2"

Choy: This has been fixed, and a new PR raised.

amilan17 avatar Aug 11 '25 08:08 amilan17

replaced with new PR for 2025-2 release

amilan17 avatar Nov 18 '25 13:11 amilan17