Willian Mitsuda
Willian Mitsuda
BTW, about the highlighter: https://github.com/otterscan/otterscan/issues/1914
fixed by migrating to Shiki
IMHO, that solution sounds more like a workaround, not a proper solution. I'd recommend leave it open.
actually, there are some other settings that should be saved in local storage, but I didn't implement because lack of time, now maybe a good opportunity. a more important one...
I would propose to turn this issue into: "persist UI settings into localstorage" and add all known (all the 2 so far :) ) settings to it.
about #1254 I think not all settings need to be synced to a long term persistence storage, i.e., it could be ok-ish to reset display settings, but may not be...
I agree. I don't want us to put anything BNB specific in our code because it is not officially supported by Erigon, but as it is now, any interested party...
yeah, I like the local storage solution bc it seems the natural choice for dapps. I'm aware of the Safari policy, don't know how annoying it is in practice.
agree, I think it was fixed by another similar issue, but couldn't find it. anyway, I tested in my phone and it doesn't overflow anymore.