wmgroot
wmgroot
I've implemented the improvements discussed with @jonathan-innis and I believe this should be ready for a final pass.
Rebased, and all requests should be implemented.
@jmdeal could I get another review if needed?
@jmdeal I believe everything requested in https://github.com/jmdeal/karpenter/blob/disruption-grace-design/designs/termination-grace-period-extension.md has been implemented and tested, and is ready for a review.
@sftim I believe you should be good to remove your hold for the out-of-service taint. Use of the taint has been removed and the feature has been tested to work...
/remove-hold
> Is this just for drift or for all disruptions (delete, replace etc)? The TGP timeout applies to all forms of node disruption. It does not allow disruption to be...
Would you mind linking the code for this special handling to me? I'm searching for any mention of "node-role" or "control-plane" label and not finding anything. I don't think it's...
I'm working on implementing a patch to deal with this issue at my company. We're running into this constantly when using Karpenter for a cluster with almost nothing but ephemeral...
We've seen almost 2300 occurrences in the last week with Gitlab CI job pods. Every pod has the do-not-disrupt annotation. This cluster has about 25 NodeClaims which are primarily used...