PDCurses icon indicating copy to clipboard operation
PDCurses copied to clipboard

Wingui port from @Bill-Gray, backported to the mainline

Open chasonr opened this issue 5 years ago • 4 comments

Here is @Bill-Gray's wingui port, plucked out of his fork and edited to compile and run with the mainline PDCurses. CMakeLists.txt is broken and I don't know enough about CMake to fix it. Makefile.bcc might be broken; I don't have a 32 bit version of Windows or a Borland compiler that might be compatible with Windows 8. The other Makefiles are all tested with and without -DWIDE=Y.

chasonr avatar Feb 27 '20 00:02 chasonr

Just so we're clear: This has no extended color, no 64 bit chtype; just the wingui port.

chasonr avatar Feb 27 '20 00:02 chasonr

Hmmm... so this is basically WinGUI modified so that it can be dropped in next to the rest of the @wmcbrine fork and compile and work with it, without requiring modification of (for example) curses.h or curspriv.h... really, of anything outside the wingui directory.

I admit to feeling somewhat conflicted about this. Obviously, it involves "dumbing down" my version rather heavily : no Unicode past the BMP, limited colors and color pairs, no fullwidth or combining characters, limited range of keystrokes, several attributes missing, etc., etc. Anyone using an Asian language is, to some degree, left out.

But I made the pull request involved four years ago, and it hasn't gone anywhere. I think we can safely assume that's a "no". Given that reality, yours is a decent solution for anyone who is, for some reason, forced into the limitations of mainline PDCurses but who would still like to use WinGUI, and I hope it gets pulled into mainline PDCurses.

I will close my original pull request, and we'll see what happens with this one.

Bill-Gray avatar Feb 27 '20 22:02 Bill-Gray

I'd like to see the greater support for Unicode and all the rest. But these features are probably best broken out into separate pull requests.

chasonr avatar Feb 28 '20 05:02 chasonr

@wmcbrine Please drop a note if "including a minimized WinGUI port" is something relevant here and may be redone/updated from current PDCursesMod or if it would be done on your side (if you find the time to include it) in any case - then closing this PR may be the reasonable way to go.

Thanks.

GitMensch avatar Sep 01 '20 06:09 GitMensch