awesome-devops icon indicating copy to clipboard operation
awesome-devops copied to clipboard

📦 Add link check action

Open TechWiz-3 opened this issue 2 years ago • 8 comments

In this PR, I have added a workflow which checks links and fails if any of them are broken.

Disclaimer: this action is my own action, the repo is here

You can view the logs of the workflow on my fork here. 2 links were found to be broken.

Let me know if you'd like me to change anything, any feedback is appreciated either way :)

TechWiz-3 avatar Jul 31 '22 12:07 TechWiz-3

Hi,

Nice workflow. The question is can we make also If the URL is safe enought?

wmariuss avatar Jul 31 '22 20:07 wmariuss

Thank you 😌

What do you mean safe enough though? If the connection is not secure (i.e. no SSL certificate) the link is considered to be broken and is added to the bad links list, I could also create an option that enforces only https links too if that's what you mean 🤔

TechWiz-3 avatar Jul 31 '22 21:07 TechWiz-3

Yes, if it has SSL cert valid, but also, the content is safe.

wmariuss avatar Aug 01 '22 09:08 wmariuss

Surely it wouldn't be added if the content isn't safe?

In any case, that would be a cool feature to explore, any ideas on how that can be measure? Also, any ideas on what defines 'safe' content?

TechWiz-3 avatar Aug 01 '22 11:08 TechWiz-3

Ok, add SSL validation for now. and in the future is good to have content validation as well.

wmariuss avatar Aug 12 '22 12:08 wmariuss

SSL validation is already in place Screen Shot 2022-08-13 at 12 19 16 am

TechWiz-3 avatar Aug 12 '22 14:08 TechWiz-3

Also don't worry about the 429 errors in the screenshot. That screenshot was taken from an update that I'm working on which hasn't been pushed yet

TechWiz-3 avatar Aug 12 '22 14:08 TechWiz-3

Any updates @wmariuss ?

TechWiz-3 avatar Aug 27 '22 01:08 TechWiz-3

Any updates @wmariuss ?

Please see the comments.

wmariuss avatar Oct 27 '22 21:10 wmariuss