PyTado icon indicating copy to clipboard operation
PyTado copied to clipboard

Add separate CONST_OVERLAY_NEXT_TIME_BLOCK to use CONST_OVERLAY_TADO_MODE for the actual TADO_MODE

Open deichcode opened this issue 6 months ago • 1 comments

In the const.py there is no overlay type/mode constant that is set to "TADO_MODE". However, this string is supported by the tado API, and if used as typeSkillBasedApp the overlay will remain until either the next time block is reached or the home state is changed.

At the moment the CONST_OVERLAY_TADO_MODE is set to "NEXT_TIME_BLOK". In contrast to the actual "TADO_MODE," this overlay remains until the time of the next time block arrives independently of the home state.

The two different types are reflected in the UI like this

TADO_MODE TADO_MODE

NEXT_TIME_BLOCK NEXT_TIME_BLOCK

Therefore, I'd suggest that CONST_OVERLAY_TADO_MODE is now set to "TADO_MODE" and a new CONST_OVERLAY_NEXT_TIME_BLOCK is introduced. Since this is a breaking change for everyone using the previous definition of CONST_OVERLAY_TADO_MODE, it should be discussed how to proceed. However, using a const named this way might have caused unintended behavior in the past.

deichcode avatar Dec 29 '23 09:12 deichcode